Rejected Change default skill xp to -1 to fix skill listener

Discussion in 'Client & Site Suggestions' started by Aidden, Jan 11, 2015.

  1. Aidden

    Aidden The better executive ;)

    Joined:
    Dec 3, 2013
    Messages:
    3,458
    Likes Received:
    708
    @Cloud would it be possible for you to change the skill class to have xp/lvl values of -1 if the skills haven't loaded? because when you login it goes from 0->yourxp and the listener thinks its an xp gain. if it was default -1 then you could just filter out events that go from xp = -1 -> x
    Also filtering out negative changes would be good. If you log in then out then back in it detects two changes for each skill, one from yourxp to 0, the other from 0 back to your xp
     
    #1 Aidden, Jan 11, 2015
    Last edited: Jan 11, 2015
  2. Cloud

    Joined:
    Jul 28, 2013
    Messages:
    2,491
    Likes Received:
    854
    Even the 0 value is taken directly from the game, it's not a fallback for when the skill data isn't loaded. Also the skill listener monitors all changes in the data, so just filter the changes out if you're not logged in when it happens.
     
  3. Aidden

    Aidden The better executive ;)

    Joined:
    Dec 3, 2013
    Messages:
    3,458
    Likes Received:
    708
    That's the problem. After being logged in and your character being loaded, it takes a second or two before the experience is set to the correct value, so the listener picks up the change even when checking for RuneScape.isLoggedIn() (RS3, not sure about osrs)
     
  4. Geashaw

    Joined:
    Jan 8, 2015
    Messages:
    1,393
    Likes Received:
    242
    I second this, noticed it when using HaxAgility and checking after a smoke break. Noticed I had been re-logged in and the paint was slowing many many skills xD.
     

Share This Page

Loading...