Don't know if this has been brought up before, but in osbot/tribot APIs you can access information about interactions. Ex: Whether an NPC is interacting with you, which NPC/Player a character is interacting with, what characters are attacking you, etc. Tribot example: RSCharacter RSCharacter Combat Is there a reason this information is not in RuneMate API? It would be a good addition if not, especially for combat bots.
There are probably less than a dozen people on this platform who know the entirety of the Runemate API. Adding more methods that just combine existing ones would make the API bloat magnitudes worse. I also really doubt you could
I don't see the point of these methods officially in the API either, isInCombat is literally just getTarget() != null. If you think isInCombat looks better then you should just make a method for it like Snuf mentioned.
There are plenty of methods that combine existing ones already. Moving to the closest bank just builds on top of navigation and GameObject scanning, clicking just builds on menu interactions and mouse api, etc etc. What the difference with this one? Well, no. I was trying to make a point. Because it serves as in-code documentation, which is good when actual documentation is lacking. player.getTarget() != null is not very obvious at first glance whereas player.isInCombat() is very hard to not understand. And obviously, it saves having to rewrite code.
In my opinion, getTarget() != null should be fairly obvious for any person with basic Java knowledge. I understand your point though, I've seen a few people throughout my time request the same thing, just not sure if I agree it's necessary.
Actually getTarget() isn't close to when you are in combat. You need to combine Check for target Check for animation Check for animation from target then it still messes up sometimes. There's a reason why a lot of the combat bots in the store mass spam NPCs while they are doing their death animation. Wouldn't be bad to just have one standardized way of checking whether your still under attack. I agree with Snufalufugus it only takes a couple of minutes and test runs to figure it out. Once you have it, you're set. But something as straight forward as checking "is in combat" shouldn't require that imo. And it could be confusing towards a lot of unexperienced developers
I agree getTarget() is wacky and can break often on RS3, but on OSRS I can't see there being any issues. If you find yourself needing animations for both your local player and target npc to determine if you are in combat, you are doing something wrong.
I made a crappy OSRS fishing/cooking/combat bot for myself a long time ago. Getting it to attack correctly was a headache. Especially because I just got into writting bots again. Using bots from the store, they nearly all mass click NPCs at some point or try to attack when still in combat.
They are also doing something wrong or just didn't bother accounting for dying NPCs. See this post: Question - Is there a better way to check if NPC is dead?
The reason it's not in the API is because being in combat is not a property of the client. There simply is no standardized way
Yeah but I think if one checks for at least one nearby NPC where npc.getTarget() == localPlayer && NPC.isHealthbarVisible(), that would be reasonably accurate.
That NPC could be a follower like a pet. Just accept that there is no universal way to tell if an Actor is in combat that's also within reasonable bounds of complexity. Make a method on your own that works for your case instead.
