1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Resolved ItemDefinition#isTradeable() broken for noted items RS3

Discussion in 'Developer Support' started by Derk, Aug 6, 2017.

  1. Derk

    Derk 12 year old normie

    Joined:
    Jan 8, 2015
    Messages:
    2,766
    Likes Received:
    1,339
    Debug information:

    Code (Javascript):
    1. 0 Falador teleport true
    2. 1 Charming imp false
    3. 2 Dungeoneering cape (t) false
    4. 3 Herbicide false
    5. 4 Air rune true
    6. 5 Cosmic rune true
    7. 6 Astral rune true
    8. 7 Gold accumulator false
    9. 8 Bonecrusher false
    10. 9 Prayer flask (6) true
    11. 10 Prayer flask (6) true
    12. 11 Monkfish true
    13. 12 Monkfish true
    14. 13 Rocktail false
    15. 14 Monkfish false
    16. 15 Rocktail true
    17. 16 Rocktail true
    Inventory slot : name : tradeable

    Actual inventory:

    [​IMG]

    As you can see, the first two unnoted monkfish are tradeable, as they are. The noted monkfish are not. The same goes for the rocktail. It doesn't happen to the stackable rune though. @Cloud

     
  2. Best Answer:
    Post #8 by Cloud, Aug 10, 2017
  3. Cloud

    Cloud Engineer

    Joined:
    Jul 28, 2013
    Messages:
    2,777
    Likes Received:
    1,124
    When did this start to occur?
     
  4. Derk

    Derk 12 year old normie

    Joined:
    Jan 8, 2015
    Messages:
    2,766
    Likes Received:
    1,339
    I've only started using it recently. I wouldn't know how far this dates back to.
     
  5. Cloud

    Cloud Engineer

    Joined:
    Jul 28, 2013
    Messages:
    2,777
    Likes Received:
    1,124
    Well I need someone to help by stating at the very least when it last was working as expected for them.
     
  6. Hyperion

    Joined:
    Nov 4, 2013
    Messages:
    856
    Likes Received:
    225
    Maybe you should inherit the value from noteTemplateId?
     
  7. Cloud

    Cloud Engineer

    Joined:
    Jul 28, 2013
    Messages:
    2,777
    Likes Received:
    1,124
    I'm pretty sure that when I rewrote all the 'transformations' based on the template and link values that I wrote them to perfectly immitate the way Jagex does it, but I may be wrong. If so, could you please show me where I'm wrong on slack?
     
  8. Overflow

    Joined:
    Mar 26, 2014
    Messages:
    33
    Likes Received:
    4
    This hasn't been updated in over a year so it may be missing a few opcodes in the decode method but looking at postDecode / update should give an idea how its handled.

    ItemComposite.class · GitHub
     
  9. Cloud

    Cloud Engineer

    Joined:
    Jul 28, 2013
    Messages:
    2,777
    Likes Received:
    1,124
    As much as I appreciate you trying to help, I'm correct about all noted items have the boolean at opcode 65 assigned the value of false :p I confirmed it with multiple technicques and with various contacts and it's true name is stockMarket and indicates if it can be sold on, well, the stock market of whatever game is being powered by the engine, in this case the grand exchange, where you can't buy an actual noted item, your items are only unnoted before being sold and noted after being bought (if you bought more than one, otherwise it's the original, unnoted version).
     

Share This Page

Loading...