[Request Feedback] Air Runecrafter

Discussion in 'Projects' started by Baddest Man on Earth, Nov 28, 2014.

  1. Baddest Man on Earth

    Joined:
    Nov 26, 2014
    Messages:
    611
    Likes Received:
    245
  2. Exia

    Joined:
    Nov 3, 2013
    Messages:
    605
    Likes Received:
    257
    I would say it's aladeen.
     
    John likes this.
  3. Baddest Man on Earth

    Joined:
    Nov 26, 2014
    Messages:
    611
    Likes Received:
    245
    [​IMG]
     
    #3 Baddest Man on Earth, Nov 28, 2014
    Last edited: Nov 28, 2014
  4. Cloud

    Joined:
    Jul 28, 2013
    Messages:
    2,568
    Likes Received:
    929
    For the most part it's better than the majority of first scripts bots. Here's some feedback on the parts that are lacking slightly
    • Interact#npc/object - You're walking in a for loop, try to avoid walking in loops. A for loop is better than a while loop but it's still suboptimal.
    • Some of your constants could be made private.
    • The loop delay may be a tad low, but if you need it then that's not a problem
    • You should use dynamic sleeping after an interaction (via the Execution class)
    • Your banking code should be revised slightly to comply with the general advice of one action per loop.
     
  5. Baddest Man on Earth

    Joined:
    Nov 26, 2014
    Messages:
    611
    Likes Received:
    245
    I was trying to get a feel for the API.

    It does help that I've wrote scripts bots for 2 other bots before.

    I'll probably rewrite my interact class tomorrow. It was the first class I wrote and the for loop is definitely reduntant once I realized how Path#step works.

    I'll try to rework things to comply be the one-action-per-loop rule and add more dynamic sleeping.

    Thanks for the fast feedback. ☺
     
  6. dog_

    dog_ 0xCAFEBABE

    Joined:
    Nov 3, 2013
    Messages:
    270
    Likes Received:
    55
  7. Baddest Man on Earth

    Joined:
    Nov 26, 2014
    Messages:
    611
    Likes Received:
    245
    I've updated the script bot according to @Cloud 's and @dog_ 's suggestions. Tell me what you think.
     
  8. Falixus

    Falixus Guest

    I have Al-Adeen news and Al-Adeen news:
    Congratulations on your first script bot. :p
     
  9. Baddest Man on Earth

    Joined:
    Nov 26, 2014
    Messages:
    611
    Likes Received:
    245
    Thanks.

    I've ran this for ~ 10 hours, made over 2.5 mil :D
     
  10. WYD

    WYD

    Joined:
    Mar 14, 2014
    Messages:
    479
    Likes Received:
    63
    Add it to the SDN Pls
     
  11. Baddest Man on Earth

    Joined:
    Nov 26, 2014
    Messages:
    611
    Likes Received:
    245
    I pushed it to the SVN, just have to wait now.
     
  12. WYD

    WYD

    Joined:
    Mar 14, 2014
    Messages:
    479
    Likes Received:
    63
    i'm so excited
     
  13. Cloud

    Joined:
    Jul 28, 2013
    Messages:
    2,568
    Likes Received:
    929
    Rejected it for a couple small reasons, should be easy for you to fix though :)
     

Share This Page

Loading...