Navigation

Navigation section

Welcome!

By registering with us, you'll be able to discuss, share and private message with other members of our community.

Sign up now!

Bug Bank.depositAllExcept() occasionally gets stuck with item right-clicked

snufalufugus

snufalufugus

Joined
Aug 23, 2015
Messages
1,970
The only information in the intelliJ output is

00:09:52 TRACE [Bank] Depositing with action: Deposit-All

It will right click the item, never select the option, and just sit there with the menu open until the account logs out from inactivity.

This is on OSRS with 7 items in the argument.
 
still unresolved 7/2/17
 
kermitt

kermitt

Joined
Jan 25, 2017
Messages
29
Deposit all except returns a boolean that lets you know if it was successful. You can do something like the following to keep trying until everything is gone. So even if it isn't perfect it wont break;

Code: 
private boolean depositAll()
    {
        if (!Bank.depositAllExcept(ITEM_IDS_TO_KEEP))
            depositAll();
       
        return true;
    }
 
snufalufugus

snufalufugus

Joined
Aug 23, 2015
Messages
1,970
Still unresolved 9/8/17

More details since I encountered it again:
Code: 
00:46:18 INFO    Opening bank to deposit bars
00:46:19 DEBUG    It has been 00:00:09 since we started processing
00:46:18 DEBUG    It has been 00:00:00 since we paid the foreman
00:46:19 INFO    We have decided to turn the camera
00:46:19 TRACE    [Camera] Camera turn direction: RIGHT / UP
00:46:19 TRACE    [Camera] Pressing keys
00:46:19 DEBUG    Found items in bank
00:46:19 INFO    Depositing unnecessary items
00:46:19 TRACE    [Bank] Depositing with action: Deposit
00:46:19 WARN    [Bank] Action not found in [Cancel, Walk here]
00:46:19 TRACE    [Bank] Depositing with action: Deposit-All
00:46:19 TRACE    [Camera] It should now release the key RIGHT which is currently pressed.
00:46:19 TRACE    [Camera] Releasing key RIGHT
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 INFO    We have been processing too long.
00:46:20 INFO    Depositing unnecessary items
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 WARN    [Bank] Action not found in [Cancel]
00:46:20 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 INFO    Depositing unnecessary items
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 WARN    [Bank] Action not found in [Cancel]
00:46:21 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 INFO    Depositing unnecessary items
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:22 WARN    [Bank] Action not found in [Cancel]
00:46:22 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 INFO    Depositing unnecessary items
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit
00:46:23 WARN    [Bank] Action not found in [Cancel]
00:46:23 TRACE    [Bank] Depositing with action: Deposit

Task where it occured:
Code: 
public class DepositUnneededItems extends Task {

    private RegalBlastFurnace bot = (RegalBlastFurnace) Environment.getBot();

    private BF_Bars currentBar;

    @Override
    public boolean validate() {
        return (currentBar = bot.getBf_bar()) != null && Inventory.containsAnyExcept(currentBar.getMaterialOne(), currentBar.getMaterialTwo(), "Coal bag", "Bucket", "Bucket of water", "Stamina potion(1)", "Stamina potion(2)", "Stamina potion(3)", "Stamina potion(4)");
    }

    @Override
    public void execute() {
        bot.getUi().setIgnoreAdditions(true);
        getLogger().info("Depositing unnecessary items");
        Bank.depositAllExcept(currentBar.getMaterialOne(), currentBar.getMaterialTwo(), "Coal bag", "Bucket", "Bucket of water", "Stamina potion(1)", "Stamina potion(2)", "Stamina potion(3)", "Stamina potion(4)");
    }

}

Image sent to @Cloud in Slack.

The bot idled until it logged out, as far as I can tell it did this without re-looping through the structure, since it never re-printed "Depositing unnecessary items".
 
silencep44

silencep44

Joined
Jun 8, 2017
Messages
187
I have the same problem but I just solve it like this:

Code: 
GameObject rndObject = GameObjects.newQuery().results().random();
if (rndObject != null) {
      if (rndObject.isVisible()) {
          Mouse.move(rndObject);
          Execution.delay(50, 2000, 150);
     }
}

The same happens allot when rightclicking on a large group of people. I just do the same with rnd objects.
 
snufalufugus

snufalufugus

Joined
Aug 23, 2015
Messages
1,970
SilenceP44 said:
I have the same problem but I just solve it like this:

Code: 
GameObject rndObject = GameObjects.newQuery().results().random();
if (rndObject != null) {
      if (rndObject.isVisible()) {
          Mouse.move(rndObject);
          Execution.delay(50, 2000, 150);
     }
}

The same happens allot when rightclicking on a large group of people. I just do the same with rnd objects.
Click to expand...
Yes, I have similar failsafes, but that doesn't mean that the API shouldn't be updated. Authors shouldn't need to implement custom failsafes like these on an individual basis to be able to use the API without their bots breaking.
 
silencep44

silencep44

Joined
Jun 8, 2017
Messages
187
True but it all comes down to that the bot thinks something is visible when not. I really don't know how hard it is to check or how much resources it would take to fix this. But indeed we shouldn't have to deal with this.
 
Top