[salvation]

Currently they return 0, which is BAD.

 

[arbiter]

@Cloud

 

[cloud]

On RS3 it'll return -1 if the skill object isn't loaded, ie logged out. On OSRS they just use int[]'s so I can't do the same style of check because they're always populated. Adding an isLoggedIn check to ever call in that is too expensive imo.

 

[salvation]

On RS3 it'll return -1 if the skill object isn't loaded, ie logged out. On OSRS they just use int[]'s so I can't do the same style of check because they're always populated. Adding an isLoggedIn check to ever call in that is too expensive imo.

Nah, this is expensive:

public class RMSkills implements Skills.Tracker.Provider {

    @Override
    public int getCurrentLevel(com.skelware.bot.data.Skill skill) {
        if (!RuneScape.isLoggedIn()) {
            return -1;
        }

        return convert(skill).getCurrentLevel();
    }

    @Override
    public int getCurrentExperience(com.skelware.bot.data.Skill skill) {
        if (!RuneScape.isLoggedIn()) {
            return -1;
        }

        return convert(skill).getExperience();
    }

    private Skill convert(com.skelware.bot.data.Skill skill) {
        return Skill.values()[skill.getGameIndex()];
    }
}

 

[cloud]

On osrs if they return 0 internally, moving forward it'll make it say -1

 

[aidden]

Might be worth looking into stopping the xp gained event from firing when logging in.