1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

pHerblore [Deleted]

Discussion in 'Bot Support & Feedback' started by Party, May 2, 2016.

Thread Status:
Not open for further replies.
  1. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
    Party submitted a new resource:

    pHerblore - Make any potion, finished or unfinished!

    Read more about this resource...
     
    #1 Party, May 2, 2016
    Last edited by a moderator: May 6, 2016
  2. snoipa

    Joined:
    Feb 21, 2016
    Messages:
    48
    Likes Received:
    10
    Is there any way that making Super Combat potions could be added to this?
     
  3. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
    Should be fully customisable, make the (unf) then make the completed ones
     
  4. snoipa

    Joined:
    Feb 21, 2016
    Messages:
    48
    Likes Received:
    10
    um... I apologize i'm not sure if i don't understand you or vice versa... but Super Combat Potions require multiple ingredients for them to be made. For example a super combat potion requires super attack, super strenght, super defence, and a torstol all in the inventory. Then using the torstol on one of the three super potions combines all of them into super combat potions. Is there any way to be able to do this with this bot or have this feature added?

    Sorry for the miscommunication.. thanks!
     
  5. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
    Ahhh... I seeee! Herblore on the account I'm using is only like 46 so it'll be difficult for me to write then test but it's definitely something I can look at.
     
  6. cretaokada

    Joined:
    Aug 26, 2015
    Messages:
    12
    Likes Received:
    3
    Regarding entering your own values into the bot - you might find this useful to add to the (I started on a herblore bot but don't know enough to make it stable):
    From UI/FXController:
    Code (Text):
    1. public class OkadaHerbloreFXController implements Initializable {
    2.  
    3.     private OkadaHerblore bot;
    4.  
    5.     @FXML
    6.     private ComboBox Potion_ComboBox;
    7.  
    8.     @FXML
    9.     private CheckBox Clean_Herbs_CheckBox;
    10.  
    11.     @FXML
    12.     private CheckBox Make_Unfinished_CheckBox;
    13.  
    14.     @FXML
    15.     private CheckBox Make_Finished_CheckBox;
    16.  
    17.     @FXML
    18.     private Button Start_BT;
    19.  
    20.  
    21.     public OkadaHerbloreFXController(OkadaHerblore bot) {
    22.         this.bot = bot;
    23.     }
    24.  
    25.     @Override
    26.     public void initialize(URL location, ResourceBundle resources) {
    27.         // Add Potions to the combo box
    28.         Potion_ComboBox.getItems().addAll(
    29.           "Attack Potion",
    30.           "Antipoison",
    31.           "Relicym's balm",
    32.           "Strength potion",
    33.           "Serum 207",
    34.           "Restore potion",
    35.           "Guthix balance",
    36.           "Energy potion",
    37.           "Defence potion",
    38.           "Agility potion",
    39.           "Combat Potion",
    40.           "Prayer potion",
    41.           "Super attack potion",
    42.           "Super antipoison",
    43.           "Fishing potion",
    44.           "Super energy potion",
    45.           "Hunter Potion",
    46.           "Super Strength potion",
    47.           "Magic Essence potion",
    48.           "Weapon poison",
    49.           "Super restore potion",
    50.           "Sanfew serum",
    51.           "Super defence potion",
    52.           "Anti-fire breath potion",
    53.           "Ranging potion",
    54.           "Magic potion",
    55.           "Zamorak brew",
    56.           "Saradomin brew"
    57.         );
    58.  
    59.         // If the Start Button is pressed, handle that even in the getStart_BTAction method
    60.         Start_BT.setOnAction(getStart_BTAction());
    61.  
    62.         // Set the event for Location_ComboBox
    63.         Potion_ComboBox.setOnAction(getPotion_ComboBoxEvent());
    64.     }
    65.  
    66.     private EventHandler<ActionEvent> getStart_BTAction() {
    67.         return event -> {
    68.             try {
    69.                 // Initialize all variables in your bot
    70.                 bot.guiWait = false;
    71.  
    72.                 // Handle CheckBoxes
    73.                 if (Clean_Herbs_CheckBox.isSelected()){
    74.                     bot.cleanHerbs = Boolean.TRUE;
    75.                 } else {
    76.                     bot.cleanHerbs = Boolean.FALSE;
    77.                 }
    78.                 if (Make_Unfinished_CheckBox.isSelected()){
    79.                     bot.makeUnfinished = Boolean.TRUE;
    80.                 } else {
    81.                     bot.makeUnfinished = Boolean.FALSE;
    82.                 }
    83.                 if (Make_Finished_CheckBox.isSelected()){
    84.                     bot.makeFinished = Boolean.TRUE;
    85.                 } else {
    86.                     bot.makeFinished = Boolean.FALSE;
    87.                 }
    88.  
    89.                 // Handle ComboBox
    90.                 switch(Potion_ComboBox.getSelectionModel().getSelectedItem().toString()){
    91.                     case "Attack Potion":
    92.                         bot.potionName = "Attack potion";
    93.                         bot.unfPotionName = "Guam potion (unf)";
    94.                         bot.herbName = "Guam leaf";
    95.                         bot.ingredientName = "Eye of newt";
    96.                         bot.requiredLvl = 3;
    97.                         break;
    98.                     case "Antipoison":
    99.                         bot.potionName = "Antipoison";
    100.                         bot.unfPotionName = "Marrentill potion (unf)";
    101.                         bot.herbName = "Marrentill";
    102.                         bot.ingredientName = "Unicorn horn dust";
    103.                         bot.requiredLvl = 5;
    104.                         break;
    105.                     case "Relicym's balm":
    106.                         bot.potionName = "Relicym's balm";
    107.                         bot.unfPotionName = "Rogue's purse potion (unf)";
    108.                         bot.herbName = "Rogue's purse";
    109.                         bot.ingredientName = "Snakeweed";
    110.                         bot.requiredLvl = 8;
    111.                         break;
    112.                     case "Strength potion":
    113.                         bot.potionName = "Strength potion";
    114.                         bot.unfPotionName = "Tarromin potion (unf)";
    115.                         bot.herbName = "Tarromin";
    116.                         bot.ingredientName = "Limpwurt root";
    117.                         bot.requiredLvl = 12;
    118.                         break;
    119.                     case "Serum 207":
    120.                         bot.potionName = "Serum 207";
    121.                         bot.unfPotionName = "Tarromin potion (unf)";
    122.                         bot.herbName = "Tarromin";
    123.                         bot.ingredientName = "Ashes";
    124.                         bot.requiredLvl = 15;
    125.                         break;
    126.                     case "Restore potion":
    127.                         bot.potionName = "Restore potion";
    128.                         bot.unfPotionName = "Harralander potion (unf)";
    129.                         bot.herbName = "Harralander";
    130.                         bot.ingredientName = "Red spider eggs";
    131.                         bot.requiredLvl = 22;
    132.                         break;
    133.                     case "Guthix balance":
    134.                         bot.potionName = "Guthix balance";
    135.                         bot.unfPotionName = "Harralander potion (unf)";
    136.                         bot.herbName = "Harralander";
    137.                         bot.ingredientName = "Garlic, Red spider eggs, silver dust";
    138.                         bot.requiredLvl = 22;
    139.                         break;
    140.                     case "Energy potion":
    141.                         bot.potionName = "Energy potion";
    142.                         bot.unfPotionName = "Harralander potion (unf)";
    143.                         bot.herbName = "Harralander";
    144.                         bot.ingredientName = "Chocolate dust";
    145.                         bot.requiredLvl = 26;
    146.                         break;
    147.                     case "Defence potion":
    148.                         bot.potionName = "Defence potion";
    149.                         bot.unfPotionName = "Ranarr potion (unf)";
    150.                         bot.herbName = "Ranarr weed";
    151.                         bot.ingredientName = "Whiteberries";
    152.                         bot.requiredLvl = 30;
    153.                         break;
    154.                     case "Agility potion":
    155.                         bot.potionName = "Agility potion";
    156.                         bot.unfPotionName = "Toadflax potion (unf)";
    157.                         bot.herbName = "Toadflax";
    158.                         bot.ingredientName = "Toad's legs";
    159.                         bot.requiredLvl = 34;
    160.                         break;
    161.                     case "Combat Potion":
    162.                         bot.potionName = "Combat Potion";
    163.                         bot.unfPotionName = "Harralander potion (unf)";
    164.                         bot.herbName = "Harralander";
    165.                         bot.ingredientName = "Ground Goat's Horn";
    166.                         bot.requiredLvl = 36;
    167.                         break;
    168.                     case "Prayer potion":
    169.                         bot.potionName = "Prayer potion";
    170.                         bot.unfPotionName = "Ranarr potion (unf)";
    171.                         bot.herbName = "Ranarr weed";
    172.                         bot.ingredientName = "Snape grass";
    173.                         bot.requiredLvl = 38;
    174.                         break;
    175.                     case "Super attack potion":
    176.                         bot.potionName = "Super attack potion";
    177.                         bot.unfPotionName = "Irit potion (unf)";
    178.                         bot.herbName = "Irit leaf";
    179.                         bot.ingredientName = "Eye of newt";
    180.                         bot.requiredLvl = 45;
    181.                         break;
    182.                     case "Super antipoison":
    183.                         bot.potionName = "Super antipoison";
    184.                         bot.unfPotionName = "Irit potion (unf)";
    185.                         bot.herbName = "Irit leaf";
    186.                         bot.ingredientName = "Unicorn horn dust";
    187.                         bot.requiredLvl = 48;
    188.                         break;
    189.                     case "Fishing potion":
    190.                         bot.potionName = "Fishing potion";
    191.                         bot.unfPotionName = "Avantoe potion (unf)";
    192.                         bot.herbName = "Avantoe";
    193.                         bot.ingredientName = "Snape grass";
    194.                         bot.requiredLvl = 50;
    195.                         break;
    196.                     case "Super energy potion":
    197.                         bot.potionName = "Super energy potion";
    198.                         bot.unfPotionName = "Avantoe potion (unf)";
    199.                         bot.herbName = "Avantoe";
    200.                         bot.ingredientName = "Mort Myre fungi";
    201.                         bot.requiredLvl = 52;
    202.                         break;
    203.                     case "Hunter Potion":
    204.                         bot.potionName = "Hunter Potion";
    205.                         bot.unfPotionName = "Avantoe potion (unf)";
    206.                         bot.herbName = "Avantoe";
    207.                         bot.ingredientName = "Kebbit teeth dust";
    208.                         bot.requiredLvl = 53;
    209.                         break;
    210.                     case "Super Strength potion":
    211.                         bot.potionName = "Super Strength potion";
    212.                         bot.unfPotionName = "Kwuarm potion (unf)";
    213.                         bot.herbName = "Kwuarm";
    214.                         bot.ingredientName = "Limpwurt root";
    215.                         bot.requiredLvl = 55;
    216.                         break;
    217.                     case "Magic Essence potion":
    218.                         bot.potionName = "Magic Essence potion";
    219.                         bot.unfPotionName = "";
    220.                         bot.herbName = "Starflower";
    221.                         bot.ingredientName = "Gorak Claw";
    222.                         bot.requiredLvl = 57;
    223.                         break;
    224.                     case "Weapon poison":
    225.                         bot.potionName = "Weapon poison";
    226.                         bot.unfPotionName = "Kwuarm potion (unf)";
    227.                         bot.herbName = "Kwuarm";
    228.                         bot.ingredientName = "Dragon scale dust";
    229.                         bot.requiredLvl = 60;
    230.                         break;
    231.                     case "Super restore potion":
    232.                         bot.potionName = "Super restore potion";
    233.                         bot.unfPotionName = "Snapdragon potion (unf)";
    234.                         bot.herbName = "Snapdragon";
    235.                         bot.ingredientName = "Red spider eggs";
    236.                         bot.requiredLvl = 63;
    237.                         break;
    238.                     case "Sanfew serum":
    239.                         bot.potionName = "Sanfew serum";
    240.                         bot.unfPotionName = "";
    241.                         bot.herbName = "Super restore potion";
    242.                         bot.ingredientName = "Ground unicorn horn, snake weed, nail beast nails";
    243.                         bot.requiredLvl = 65;
    244.                         break;
    245.                     case "Super defence potion":
    246.                         bot.potionName = "Super defence potion";
    247.                         bot.unfPotionName = "Cadantine potion (unf)";
    248.                         bot.herbName = "Cadantine";
    249.                         bot.ingredientName = "Whiteberries";
    250.                         bot.requiredLvl = 66;
    251.                         break;
    252.                     case "Anti-fire breath potion":
    253.                         bot.potionName = "Anti-fire breath potion";
    254.                         bot.unfPotionName = "Lantadyme potion (unf)";
    255.                         bot.herbName = "Lantadyme";
    256.                         bot.ingredientName = "Dragon scale dust";
    257.                         bot.requiredLvl = 69;
    258.                         break;
    259.                     case "Ranging potion":
    260.                         bot.potionName = "Ranging potion";
    261.                         bot.unfPotionName = "Dwarf weed potion (unf)";
    262.                         bot.herbName = "Dwarf weed";
    263.                         bot.ingredientName = "Wine of Zamorak";
    264.                         bot.requiredLvl = 72;
    265.                         break;
    266.                     case "Magic potion":
    267.                         bot.potionName = "Magic potion";
    268.                         bot.unfPotionName = "Lantadyme potion (unf)";
    269.                         bot.herbName = "Lantadyme";
    270.                         bot.ingredientName = "Potato Cactus";
    271.                         bot.requiredLvl = 76;
    272.                         break;
    273.                     case "Zamorak brew":
    274.                         bot.potionName = "Zamorak brew";
    275.                         bot.unfPotionName = "Torstol potion (unf) ";
    276.                         bot.herbName = "Torstol";
    277.                         bot.ingredientName = "Jangerberries";
    278.                         bot.requiredLvl = 78;
    279.                         break;
    280.                     case "Saradomin brew":
    281.                         bot.potionName = "Saradomin brew";
    282.                         bot.unfPotionName = "Toadflax potion (unf)";
    283.                         bot.herbName = "Toadflax";
    284.                         bot.ingredientName = "Crushed Bird's Nest";
    285.                         bot.requiredLvl = 81;
    286.                         break;
    287.                 }
    288.                 // Set the EmbeddableUI property to reflect your Info GUI
    289.                 Platform.runLater(() -> bot.setToInfoProperty());
    290.  
    291.             } catch (Exception e) {
    292.                 e.printStackTrace();
    293.             }
    294.         };
    295.     }
    And just initialize these vars in the main <botname>.java file:
    Code (Text):
    1.     public String potionName;
    2.     public String unfPotionName;
    3.     public String herbName;
    4.     public String ingredientName;
    5.     private String vialName = "Vial of water";
    Some are missing (such as super combat as mentioned) but that would be harder to do. Feel free to use it, was a PITA to pull that info out :p
     
  7. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
    I'd probably just make a huge-fuckoff enum or something to store all of that, too chunky for a controller imo ^^
     
  8. cretaokada

    Joined:
    Aug 26, 2015
    Messages:
    12
    Likes Received:
    3
    Yeah it's pretty fugly too :p
     
  9. wikte

    Joined:
    Mar 16, 2016
    Messages:
    99
    Likes Received:
    9
    bot stops working on level up until u correct it...
    --- Double Post Merged, May 13, 2016, Original Post Date: May 13, 2016 ---
    Could you add method with noted third ingredient?

    Something like this:
    --- Double Post Merged, May 16, 2016 ---
    Could u add at least herb cleaning?
     
  10. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
    Hey, sorry for not replying earlier.

    My priorities currently lie elsewhere. However, looking over my old code makes me really sad, so rest assured this bot will be getting a full overhaul in the near(ish) future.
     
    wikte likes this.
  11. wikte

    Joined:
    Mar 16, 2016
    Messages:
    99
    Likes Received:
    9
    if it's not a secret, on what are you working on?
     
  12. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
    Massive revamp of Pest Control bot. Want it to be flawless.

    I'm also rolling out my generic UI to all future bots (including rewrites) and any current bots that are worth it.
     
  13. thrados

    Joined:
    Apr 26, 2016
    Messages:
    7
    Likes Received:
    0
    Is it me or is the bot not continuing after level up? It gets stuck there for me.
     
  14. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
    Yeah it's a little sketchy at the moment - it's on the to-fix list though :)
     
    skeetles likes this.
  15. boy9959

    boy9959 The man who can

    Joined:
    Dec 14, 2015
    Messages:
    91
    Likes Received:
    10
    It gets stuck when you level up
    --- Double Post Merged, May 18, 2016, Original Post Date: May 18, 2016 ---
    Wow I'm special I need to learn to read previous posts before commenting. I cri
     
    skeetles likes this.
  16. skeetles

    Joined:
    Sep 22, 2015
    Messages:
    58
    Likes Received:
    12
    Even with the latest patch it still gets stuck on leveling up, besides that working flawless.

    (by stuck I have to finish creating the potions manually for the bot to continue or it will eventually logout)
     
  17. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
    Oh shit totally forgot to do that haha, latest update was just UI fix. Yeah ez fix I'll push tonight, not sure when it'll go to botstore though.
     
    skeetles likes this.
  18. skeetles

    Joined:
    Sep 22, 2015
    Messages:
    58
    Likes Received:
    12
    Ah sweet, love your 07 bots bro. make more :p
     
  19. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
  20. Party

    Party Client Developer

    Joined:
    Oct 12, 2015
    Messages:
    3,708
    Likes Received:
    1,606
Thread Status:
Not open for further replies.

Share This Page

Loading...