[aidden]

Enters username and password in the username field

 

[arbiter]

@Cloud sounds game-breaking.

 

[cloud]

OSRS or RS3?

 

[aidden]

OSRS or RS3?

Rs3, haven't tested osrs

 

[aidden]

@Cloud Did you attempt to fix this? It seems to be working now which is weird if you didn't because i tested it multiple times. OSRS is also working fine.

 

[aidden]

@Cloud Still experiencing some issues with this. It doesn't seem to wait long enough between clicking password and typing it so sometimes it'll type part of the password in the username field

 

[cloud]

Some updates to this are coming in the next update.

 

[aidden]

Some updates to this are coming in the next update.

Sounds good

 

[aidden]

Still having an issue with this. It sometimes enters the first letter of the password at the end of the username (Only tested rs3).
@Cloud

 

[cloud]

I've added a small delay after the click so that should resolve the issue.

 

[aidden]

I've added a small delay after the click so that should resolve the issue.

Thanks. Also just as a note, you can press enter to both change from username field to password and send the login request

 

[arbiter]

I've added a small delay after the click so that should resolve the issue.

I do not think that is the right solution. The LoginHandler should be more fault tolerant and validate entries. Any amount of delay could be proven useless with enough resource throttling. I suggest rule based validation before login submission (making sure the username field text matches the desired username, making sure the password field length matches the desired password, etc.). Additionally, it should have error handling based on failed validation and server response (username deletion and re-entry on failed validation, password re-entry on failed server authentication, bot stop on X failed attempts, etc.).

P.S. My suggestion for X is 3, to prevent repeated failed server authentication from locking a user. I believe Jagex's limit for number of attempts is 5 per 5 minutes.

 

[cloud]

I do not think that is the right solution. The LoginHandler should be more fault tolerant and validate entries. Any amount of delay could be proven useless with enough resource throttling. I suggest rule based validation before login submission (making sure the username field text matches the desired username, making sure the password field length matches the desired password, etc.). Additionally, it should have error handling based on failed validation and server response (username deletion and re-entry on failed validation, password re-entry on failed server authentication, bot stop on X failed attempts, etc.).

P.S. My suggestion for X is 3, to prevent repeated failed server authentication from locking a user. I believe Jagex's limit for number of attempts is 5 per 5 minutes.

The username and password field are both checked before it clicks login as it is.