Welcome!

By registering with us, you'll be able to discuss, share and private message with other members of our community.

Sign up now!

Resolved ItemDefinition#isTradeable() broken for noted items RS3

12 year old normie
Joined
Jan 8, 2015
Messages
2,768
Debug information:

JavaScript:
0 Falador teleport true
1 Charming imp false
2 Dungeoneering cape (t) false
3 Herbicide false
4 Air rune true
5 Cosmic rune true
6 Astral rune true
7 Gold accumulator false
8 Bonecrusher false
9 Prayer flask (6) true
10 Prayer flask (6) true
11 Monkfish true
12 Monkfish true
13 Rocktail false
14 Monkfish false
15 Rocktail true
16 Rocktail true

Inventory slot : name : tradeable

Actual inventory:

4veurjsLTYeOpsA71lrMZQ.png


As you can see, the first two unnoted monkfish are tradeable, as they are. The noted monkfish are not. The same goes for the rocktail. It doesn't happen to the stackable rune though. @Cloud
 
Engineer
Joined
Jul 28, 2013
Messages
2,776
Maybe you should inherit the value from noteTemplateId?
I'm pretty sure that when I rewrote all the 'transformations' based on the template and link values that I wrote them to perfectly immitate the way Jagex does it, but I may be wrong. If so, could you please show me where I'm wrong on slack?
 
Joined
Mar 26, 2014
Messages
33
I'm pretty sure that when I rewrote all the 'transformations' based on the template and link values that I wrote them to perfectly immitate the way Jagex does it, but I may be wrong. If so, could you please show me where I'm wrong on slack?
This hasn't been updated in over a year so it may be missing a few opcodes in the decode method but looking at postDecode / update should give an idea how its handled.

ItemComposite.class · GitHub
 
Engineer
Joined
Jul 28, 2013
Messages
2,776
This hasn't been updated in over a year so it may be missing a few opcodes in the decode method but looking at postDecode / update should give an idea how its handled.

ItemComposite.class · GitHub
As much as I appreciate you trying to help, I'm correct about all noted items have the boolean at opcode 65 assigned the value of false :p I confirmed it with multiple technicques and with various contacts and it's true name is stockMarket and indicates if it can be sold on, well, the stock market of whatever game is being powered by the engine, in this case the grand exchange, where you can't buy an actual noted item, your items are only unnoted before being sold and noted after being bought (if you bought more than one, otherwise it's the original, unnoted version).
 
Top