Suggestion Replace RS3Event and OSRSEvent enums with RSEvents class

The OSRSEvent and RS3Event enums are the two most branched parts of our API and I really don't like that. I want to consolidate the OSRSEvent and RS3Event enums into a single RSEvents class. The downside to this is it would no longer be an enum, which means that getting instances of RSEvent to disable/enable would require you to pass in the event name. I can make it easier for you to get the event name by providing a mapping in the javadocs.

Your code would probably change from

Code (Text):

1.  
2. if(Environment.isRS3()){
3. RS3Event.LOBBY_HANDLER.disable();
4. }else{
5. OSRSEvent.LOBBY_HANDLER.disable();
6. }
7.  

To a single statement of

Code (Text):

1.  
2. RSEvents.get("Lobby Handler").disable();
3.  

Any thoughts or suggestions on it?

 

The biggest problem that I could think of is that instead of having absolute enum values, you'd have to figure out the string for the event.

 

That's not doable though because OSRS and RS3 have very different events. If it was possible, I would have just done that from the beginning lol