[cloud]

The OSRSEvent and RS3Event enums are the two most branched parts of our API and I really don't like that. I want to consolidate the OSRSEvent and RS3Event enums into a single RSEvents class. The downside to this is it would no longer be an enum, which means that getting instances of RSEvent to disable/enable would require you to pass in the event name. I can make it easier for you to get the event name by providing a mapping in the javadocs.

Your code would probably change from

if(Environment.isRS3()){
RS3Event.LOBBY_HANDLER.disable();
}else{
OSRSEvent.LOBBY_HANDLER.disable();
}

To a single statement of

RSEvents.get("Lobby Handler").disable();

Any thoughts or suggestions on it?

 

[aidden]

I don't see any problem with that

 

[cloud]

I don't see any problem with that

The biggest problem that I could think of is that instead of having absolute enum values, you'd have to figure out the string for the event.

 

[aidden]

The biggest problem that I could think of is that instead of having absolute enum values, you'd have to figure out the string for the event.

you could have an enum thats just a list of the events and we just parse that?

 

[cloud]

you could have an enum thats just a list of the events and we just parse that?

That's not doable though because OSRS and RS3 have very different events. If it was possible, I would have just done that from the beginning lol

 

[aidden]

That's not doable though because OSRS and RS3 have very different events. If it was possible, I would have just done that from the beginning lol

Well the only difference would be we'd be putting the enum value instead of a string. The enum would only be there to store the strings that we wouldn't otherwise know.