[chieftain]

-It is not detecting the items in the inventory.

These are both coming up false,yet i have a glory,and a Rune scimitar.

public boolean invHasGlory() {
        return Inventory.contains(t -> t.getId() == GLORY[0] || t.getId() == GLORY[1] || t.getId() == GLORY[2]
                || t.getId() == GLORY[3] || t.getId() == GLORY[4] || t.getId() == GLORY[5]);
    }

    public boolean invHasWeapon() {
        return Inventory.contains(script.getWeapon());
    }

-it is not detecting the items equipped either .

public boolean equipHasWeapon() {
        return Equipment.contains(script.getWeapon());
    }
public boolean equipHasGlory() {
        return Equipment.contains(t -> t.getId() == GLORY[0] || t.getId() == GLORY[1]
                || t.getId() == GLORY[2] || t.getId() == GLORY[3] || t.getId() == GLORY[4] || t.getId() == GLORY[5]);
    }

-It seems to be detecting items in the bank but is unable to interact with it,it just hovers over the item.

public boolean withDrawGlory() {
    return Bank.withdraw("Amulet of glory(6)",1);
}

public boolean withdrawWeapon(){
    return Bank.withdraw(script.getWeapon(), 1);
}

 

[savior]

Don't use ids, and the name you specified in withDrawGlory() is wrong.

 

[chieftain]

Don't use ids, and the name you specified in withDrawGlory() is wrong.

I tried using names same thing happens, and the name for glory is correct it was working before update.

 

[savior]

I tried using names same thing happens, and the name for glory is correct it was working before update.

Pretty sure there must be a space between the name of the item and the charges?

 

[chieftain]

Pretty sure there must be a space between the name of the item and the charges?

Well its still not working,just hovers over the item,even tried the id.This is for osrs by the way. -.-

 

[geashaw]

I'm assuming null checks should be done here, but I could be wrong, like usual.

 

[savior]

I'm assuming null checks should be done here, but I could be wrong, like usual.

Where?

 

[dark sage]

why not use a pattern for the inv/equip query checks? you wouldn't need to define the charges using a pattern as query, and triple check the glory name in bank#withdraw

ignore the pattern, didn't think about the needed to know if its charged

 

[chieftain]

Listen,can u guys just check if withdrawing,equipment and inventory osrs works for yall,so we can cut this short.

 

[savior]

Listen,can u guys just check if withdrawing,equipment and inventory osrs works for yall,so we can cut this short.

If it wasn't, you'd probably see a lot of bug reports happening. Besides there was no recent update was there?

 

[geashaw]

Where?

You don't?

 

[savior]

You don't?

No, he is not querying anything from the game that might not be loaded.

 

[geashaw]

No, he is not querying anything from the game that might not be loaded.

Okioki, my bad, carry on

 

[qosmiof2]

Use queries. life is easier.

 

[savior]

Use queries. life is easier.

For what exactly is he supposed to use queries? The API usage is valid except the use of ids

 

[qosmiof2]

For what exactly is he supposed to use queries? The API usage is valid except the use of ids

public boolean invHasGlory() {       
 return !Inventory.newQuery().names(doperegexpattern).results().isEmpty();
}

 

[savior]

public boolean invHasGlory() {      
return !Inventory.newQuery().names(doperegexpattern).results().isEmpty();
}

Oh that's what you mean. Yeah that would actually be faster too.

 

[qosmiof2]

Oh that's what you mean. Yeah that would actually be faster too.

What did you think